Skip to content

Conversation

@aorinevo
Copy link

@aorinevo aorinevo commented Aug 21, 2018

Notable Changes

Remove ident property from options in examples

Type

  • Docs

Issues

SemVer

  • Fix (:label: Patch)

Checklist

  • Lint and unit tests pass with my changes
  • I have added tests that prove my fix is effective/works (if needed)
  • I have added necessary documentation (if appropriate)
  • Any dependent changes are merged and published in downstream modules

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.302% when pulling bb625bb on aorinevo:FEATURE/I-388_master_AN_ident_docs into 7647ac9 on postcss:master.

@michael-ciniawsky michael-ciniawsky changed the title I-388: Remove ident property from options in docs. docs(readme): remove custom ident from options Aug 21, 2018
@michael-ciniawsky michael-ciniawsky added this to the 3.0.1 milestone Aug 21, 2018
@jonathantneal
Copy link

@michael-ciniawsky, given your remarks in #388, would you like to close this?

@alexander-akait
Copy link
Member

I think we need search issue when postcss loader doesn't work without ident and add tests for this case to avoid future regressions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove ident property from options in docs

5 participants